core: skip scheduling tasks if JOBSERVICE_URL is not set #19045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19045 +/- ##
==========================================
- Coverage 67.41% 67.40% -0.02%
==========================================
Files 993 993
Lines 108896 108896
Branches 2751 2751
==========================================
- Hits 73413 73402 -11
- Misses 31537 31544 +7
- Partials 3946 3950 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: bin liu <[email protected]>
liubin
force-pushed
the
fix/skip-if-jobservice-is-not-set
branch
from
20c73eb
to
18c4e2f
Compare
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Skip scheduling tasks if JOBSERVICE_URL is not set, this can avoid printing much error logs for about 5 minutes until health check failed.
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: